Skip to content

Added ISO 8601 date to the SettingsPaneThemeViewModel #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

Added ISO 8601 date to the SettingsPaneThemeViewModel #3947

merged 1 commit into from
Sep 5, 2025
+2 −1

Conversation

PatrikHed
Copy link
Contributor

Since the ISO 8601 date format was missing as an option in settings, I added it to the list of options.

@github-actions github-actions bot added this to the 2.0.0 milestone Sep 5, 2025
@coderabbitai coderabbitai bot added the enhancement New feature or request label Sep 5, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 5, 2025

📝 Walkthrough

Walkthrough

Adds "yyyy-MM-dd" to the DateFormatList in SettingsPaneThemeViewModel.cs and inserts a trailing comma after the preceding "dd MMMM yyyy" entry. No changes to public APIs or other logic.

Changes

Cohort / File(s) Change summary
Theme settings date formats
Flow.Launcher/SettingPages/ViewModels/SettingsPaneThemeViewModel.cs		 Extended DateFormatList by adding "yyyy-MM-dd"; adjusted preceding line syntax with trailing comma.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • jjw24
  • Garulf
  • taooceros
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
Flow.Launcher/SettingPages/ViewModels/SettingsPaneThemeViewModel.cs (2)

176-176: Quote hyphens for consistency with existing patterns

Other hyphenated formats in this list use quoted literals (e.g., "MM'-'dd"). Align this entry for consistency and to avoid future confusion.

-        "yyyy-MM-dd"
+        "yyyy'-'MM'-'dd'"

199-202: Consider InvariantCulture for strict ISO 8601 rendering

If the intent is strict ISO 8601 (ASCII digits regardless of UI culture), render with InvariantCulture when the ISO pattern is selected.

public string DateText =>
    DateFormat == "yyyy'-'MM'-'dd'"
        ? DateTime.Now.ToString(DateFormat, CultureInfo.InvariantCulture)
        : DateTime.Now.ToString(DateFormat, CultureInfo.CurrentUICulture);

Is the requirement “strict ISO 8601” (ASCII digits) or “locale-aware but ISO-shaped”?

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 738a27e and 860ef60.

📒 Files selected for processing (1)
  • Flow.Launcher/SettingPages/ViewModels/SettingsPaneThemeViewModel.cs (1 hunks)
🔇 Additional comments (1)
Flow.Launcher/SettingPages/ViewModels/SettingsPaneThemeViewModel.cs (1)

175-176: ISO 8601 format addition looks good

The new "yyyy-MM-dd" option integrates cleanly; the preceding comma adjustment is correct.

@VictoriousRaptor VictoriousRaptor merged commit 0c9dd46 into Flow-Launcher:dev Sep 5, 2025
6 checks passed
@jjw24 jjw24 mentioned this pull request Sep 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@VictoriousRaptor VictoriousRaptor VictoriousRaptor approved these changes

Assignees

@PatrikHed PatrikHed

Labels

enhancement New feature or request

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PatrikHed @VictoriousRaptor